Conversation
- Added nova-bar 0.1.1
You can view here the package https://github.com/novik133/NovaBar/releases/tag/v0.1.1
Added nova-bar package
|
Hi, welcome to the Solus packages repo! The packaging work looks good with a few small issues, but I do not see a New Package Request for nova-bar For now I will mark this PR as a draft |
Done, i just created a new issue. |
|
Is this not approved here? #7531 |
|
I blame the search! Sorry @SnowsSky |
Reordered build and runtime dependencies for nova-bar. (changed the order)
I just updated my branch (i changed dependencies order to match with the warnings), incase the PR can't work cause of that |
There was a problem hiding this comment.
See the inline comments about your package.yml. Also:
- You will need to squash all your commit into one when done with your changes
- Title your one commit something like:
nova-bar: Add at v1.x
Don't get too discouraged, there is a lot to learn all at once when you start packaging. This is a very good start. You can also join our Matrix room for packaging and ask questions there if you like.
| - https://github.com/novik133/NovaBar/archive/refs/tags/v0.1.1.tar.gz : 3582528d1185020f3a2eaee8844a48791c068c4df283bb50dcde59fe4ff2844d | ||
| homepage : https://github.com/novik133/NovaBar | ||
| license : GPL-3.0 | ||
| component : desktop.environnement |
There was a problem hiding this comment.
This should be desktop.xfce I think.
desktop.environment is not on the list from eopkg lc
| source : | ||
| - https://github.com/novik133/NovaBar/archive/refs/tags/v0.1.1.tar.gz : 3582528d1185020f3a2eaee8844a48791c068c4df283bb50dcde59fe4ff2844d | ||
| homepage : https://github.com/novik133/NovaBar | ||
| license : GPL-3.0 |
There was a problem hiding this comment.
The complete license string is GPL-3.0-or-later, refer to the SPDX license list
| - pkgconfig(libnm) | ||
| - pkgconfig(libwnck-3.0) | ||
| - vala | ||
| rundeps: |
There was a problem hiding this comment.
Are you sure you need to add all these rundeps? If a rundep is added automatically by being used as a builddep, we don't need to add it again under rundeps. I would suggest you try removing all the rundeps and see if the program still runs. Add theme back in as needed to deal with errors
| - libnm | ||
| - libwnck-3.0 | ||
| setup : | | ||
| meson setup build --prefix=/usr |
There was a problem hiding this comment.
We always try use our Solus macros instead of calling build systems like meson directly. Macros are listed here. Try just %meson_configure for this step
There was a problem hiding this comment.
i tried with the macros but i always get an error it's like: includes dir not found with the macros
| setup : | | ||
| meson setup build --prefix=/usr | ||
| build : | | ||
| ninja -C build |
There was a problem hiding this comment.
Again, you should try a macro: %ninja_build
| build : | | ||
| ninja -C build | ||
| install : | | ||
| DESTDIR=$installdir ninja -C build install |
There was a problem hiding this comment.
Macro again: %ninja_install
3 participants
Summary
Added nova-bar package
Resolves #7531
Test Plan
Checklist